https://bugzilla.redhat.com/show_bug.cgi?id=2267876 Jan Grulich <jgrulich@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(loise@xxxxxxx) --- Comment #4 from Jan Grulich <jgrulich@xxxxxxxxxx> --- 1) Looks like BR: qt6-qtbase-static and qt6-qtdeclarative-static are not needed? At least I can build it without it and don't see any complain 2) The commented workaround can be dropped if the issue was fixed in GCC? 3) Was there an alternative of the cooker binary in Qt5? If not, we might not need to add the -qt6 suffix? 4) I think the thing checking "QMAKE_PRL_BUILD_DIR" is not needed? I guess it's not needed in any of Qt6 package we have and should be perhaps removed? I'm guessing because it's qmake related and we don't use qmake anymore. I also don't see any *.la library being installed. 5) Shouldn't this package own %{_qt6_libdir}/cmake/Qt6Quick3DPhysics and similar directories? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2267876 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202267876%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
