https://bugzilla.redhat.com/show_bug.cgi?id=2232543 --- Comment #3 from Jens Petersen <petersen@xxxxxxxxxx> --- Thank you for looking at the package. (In reply to Kan-Ru Chen from comment #2) > Note: I snipped lots of unused-direct-shlib-dependency and > undefined-non-weak-symbol errors from the rpmlint result. There > are just too many ~ 2,000 lines. I assume those are just false > positives related to how GHC library packages are generated. Right... unfortunately upstream is taking a long time addressing this longstanding issue. Let me open a PR to cover it in the Haskell Packaging Policy. > > There's no MUST violations so I think this package should be approved. > > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > > Issues: > ======= > - SHOULD: The changelog should be generated automatically from git commit > logs > using the %autochangelog macro I generally do this after importing, but yes it is good point. Perhaps I should try start to do reviews with it. > - SHOULD: Packages should contain them for all executables. > Note: W: no-manual-page-for-binary jl I think I should update cabal-rpm to handle this. Otherwise I can add it in, with help2man. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2232543 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202232543%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
