https://bugzilla.redhat.com/show_bug.cgi?id=2247059 --- Comment #3 from Jens Petersen <petersen@xxxxxxxxxx> --- Thank you for looking at the package. (In reply to Kan-Ru Chen from comment #2) > 1. The License field matches the declaration in the README.md file but > the Cabal file indicates the package might be GPL-3.0-only, > as shown on the hackage page > (https://hackage.haskell.org/package/ostree-pin) Right this is a limitation of older Haskell Cabal: it doesn't distinguish GPLv3 and GPLv3+ etc But indeed the intent is what it is written in the readme file. I should probably just bite the bullet and move the .cabal file to newer Cabal which support SPDX tags. > 2. The changelog should be generated automatically from git > commit logs using the %autochangelog macro. Yes I can convert autospec after importing - it is more awkward during the review process. Hm would be good to improve that actually. > 3. Missing manpage. Packages should contain them for all executables. Okay I can generate a manpage from the --help output. > 5. rpmlint W: position-independent-executable-suggested > It seems GHC can build PIE binaries but I'm not familiar if this is > normally applied to Fedora haskell packages. Yeah I should update the Haskell Policy to mention this explicitly perhaps. Dynamic linking probably solves this, but currently we choose to link Haskell statically. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2247059 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202247059%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
