https://bugzilla.redhat.com/show_bug.cgi?id=2260849 --- Comment #8 from Felix Maurer <felix@xxxxxxxxxxxxxxx> --- Spec URL: https://fmaurer.fedorapeople.org/stgit-2.4.0-5/stgit.spec SRPM URL: https://fmaurer.fedorapeople.org/stgit-2.4.0-5/stgit-2.4.0-5.fc40.src.rpm Some further notes: - While working on this, I noticed that all builds would print the invocations of rustc with flags, so I'm pretty sure your comment 3. doesn't really apply. - Just adding `%cargo_test` to run the unit tests would lead to stgit and a bunch of dependencies being build three times: once in the normal build, once for the unit tests (because RUST_BOOTSTRAP was different for the cargo macros and the makefile), and once again for the stgit tests (because RUST_BOOTSTRAP then switches back to the makefile state). I think I have solved the recompilation issues once and for all by passing `CARGO="%{__cargo}"` to make all the time. I don't see any recompilation now. - I included the patch from upstream to get rid of the deprecation warnings, just to be safe. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2260849 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260849%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
