https://bugzilla.redhat.com/show_bug.cgi?id=2260849 --- Comment #7 from Felix Maurer <felix@xxxxxxxxxxxxxxx> --- Thanks for the review! I have the following notes: 1. Will do. That was the result of an old rust2rpm. 2. Will do. 3. The actual build does not run with `--quiet`? Locally and in the copr logs I can see the rustc invocations with all the compiler flags. The output with `--quiet` is from `cargo run` for generation of completions and testing. But that always ends with "Fresh stgit", i.e., there is nothing being compiled. I can of course patch the `--quiet` out of the Makefile, but I think that adds patches and derivation from upstream for no benefit. 4. Will do. 5. I'm not sure I got the whole (un-)owned directory thing correctly. I don't think stgit should co-own these directories. emacs-filesystem is definitely missing. vim-filesystem is already Required and I only write to directories that belong to it (%{_datadir}/vim/vimfiles/ftdetect/ and %{_datadir}/vim/vimfiles/syntax/). To I still need to add vim-data for %{_datadir}/vim/ and %{_datadir}/vim/vimfiles/ which I don't directly use? Should it be my task to include that and not rather the task of vim-filesystem? 6. Will do. I don't think the cargo tests add something substantial over the stgit tests, but let's run them anyways. 7. This has been deprecated in indexmap (2.2.0) between when I wrote the spec file and now. The warnings have been fixed in upstream stgit in [1], part of 2.4.3, which we can not package right now because it needs a newer rust-gix. It's a small patch in stgit and it actually changes the semantics from swap_take/swap_remove to shift_take/shift_remove; not sure if this really fixes some bug. Should I include that patch? [1]: https://github.com/stacked-git/stgit/commit/d20f35d0cdf3acda8570164c6e6371bdaa1de4d3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2260849 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260849%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
