https://bugzilla.redhat.com/show_bug.cgi?id=2208398 Petr Menšík <pemensik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #11 from Petr Menšík <pemensik@xxxxxxxxxx> --- (In reply to Davide Cavalca from comment #10) > (In reply to Petr Menšík from comment #7) > > The primary problem is there is no %license in %files section. %ľicense > > LICENSE is missing. No file is installed into /usr/share/licenses/ and that > > is not optional. That have not changed after comment #5 update. > > This is already taken care of by the %pyproject_save_files macro (see the > README at https://src.fedoraproject.org/rpms/pyproject-rpm-macros for > details). You can confirm that the license file is being included and > correctly marked as %license with: > This is what I got after fedpkg --release rawhide local done on comment #5 spec file: $ rpm -qpl x86_64/python3-pyasn-1.6.1-2.fc41.x86_64.rpm /usr/bin/pyasn_util_asnames.py /usr/bin/pyasn_util_convert.py /usr/bin/pyasn_util_download.py /usr/lib/.build-id /usr/lib/.build-id/c3 /usr/lib/.build-id/c3/afbbb4e40c81f2a8e6a284fbebe091f13b5ddf /usr/lib64/python3.11/site-packages/pyasn /usr/lib64/python3.11/site-packages/pyasn-1.6.1.dist-info /usr/lib64/python3.11/site-packages/pyasn-1.6.1.dist-info/INSTALLER /usr/lib64/python3.11/site-packages/pyasn-1.6.1.dist-info/LICENSE /usr/lib64/python3.11/site-packages/pyasn-1.6.1.dist-info/METADATA /usr/lib64/python3.11/site-packages/pyasn-1.6.1.dist-info/WHEEL /usr/lib64/python3.11/site-packages/pyasn-1.6.1.dist-info/top_level.txt /usr/lib64/python3.11/site-packages/pyasn/__init__.py /usr/lib64/python3.11/site-packages/pyasn/__pycache__ /usr/lib64/python3.11/site-packages/pyasn/__pycache__/__init__.cpython-311.opt-1.pyc /usr/lib64/python3.11/site-packages/pyasn/__pycache__/__init__.cpython-311.pyc /usr/lib64/python3.11/site-packages/pyasn/__pycache__/_version.cpython-311.opt-1.pyc /usr/lib64/python3.11/site-packages/pyasn/__pycache__/_version.cpython-311.pyc /usr/lib64/python3.11/site-packages/pyasn/__pycache__/mrtx.cpython-311.opt-1.pyc /usr/lib64/python3.11/site-packages/pyasn/__pycache__/mrtx.cpython-311.pyc /usr/lib64/python3.11/site-packages/pyasn/_version.py /usr/lib64/python3.11/site-packages/pyasn/mrtx.py /usr/lib64/python3.11/site-packages/pyasn/pyasn_radix.cpython-311-x86_64-linux-gnu.so /usr/share/doc/python3-pyasn /usr/share/doc/python3-pyasn/BACKLOG.txt /usr/share/doc/python3-pyasn/README.md $ rpm -qp x86_64/python3-pyasn-1.6.1-2.fc41.x86_64.rpm -L /usr/lib64/python3.11/site-packages/pyasn-1.6.1.dist-info/LICENSE Okay, this is quite unexpected to me. I have expected license files would land always into /usr/share/licenses/python3-pyasn, like for other packages. But since the license file is correctly marked as a license file and is optional, then everything needed for successful review is present. I think I would fill a request to put at least symlink into /usr/share/licenses, so it is easier to find the actual license text. I have never had to use rpm -q --licensefiles until now, I expect I would not be the only one surprised. Anyway, review passed. Please continue with importing the package! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2208398 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202208398%23c11 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
