[Bug 2264307] Review Request: mingw-qt6-qtscxml - SCXML and StateMachine QT6 modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2264307

Sandro Mani <manisandro@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+
             Status|ASSIGNED                    |POST



--- Comment #8 from Sandro Mani <manisandro@xxxxxxxxx> ---
Only remaining comment:

%dir %{mingw32_includedir}/qt6/QtScxml/
%dir %{mingw32_includedir}/qt6/QtStateMachine/
%dir %{mingw32_includedir}/qt6/QtScxmlQml/
%dir %{mingw32_includedir}/qt6/QtStateMachineQml/
%{mingw32_includedir}/qt6/QtScxml/
%{mingw32_includedir}/qt6/QtStateMachine/
%{mingw32_includedir}/qt6/QtScxmlQml/
%{mingw32_includedir}/qt6/QtStateMachineQml/

this is reduntant, as

%{mingw32_includedir}/qt6/QtScxml/
%{mingw32_includedir}/qt6/QtStateMachine/
%{mingw32_includedir}/qt6/QtScxmlQml/
%{mingw32_includedir}/qt6/QtStateMachineQml/

own both the directory and the containing files. The problem is that if you
write i.e.

%{mingw32_libdir}/qt6/plugins/scxmldatamodel/qscxmlecmascriptdatamodel.dll

then %{mingw32_libdir}/qt6/plugins/scxmldatamodel/ is unowned. But i.e. writing

%{mingw32_libdir}/qt6/plugins/scxmldatamodel/

would own both the folder and the entire tree of contained folders/files.

Please fix this before importing. Rest looks good, approved.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2264307

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202264307%23c8
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux