https://bugzilla.redhat.com/show_bug.cgi?id=2261201 --- Comment #14 from Tim Flink <tflink@xxxxxxxxxx> --- I realize that the test binaries aren't being built normally but why make the test binaries arch specific instead of building it for all arches like the library is built? However, I'm not sure how to handle the license file text since upstream only includes MIT text. I've asked about how this has been handled in the past: https://lists.fedoraproject.org/archives/list/packaging@xxxxxxxxxxxxxxxxxxxxxxx/message/FJCX5VM5XQP3Y3K4SY25SDAAX6ULTQEA/ (In reply to Tom Rix from comment #5) <snip> > The db's. I am not sure what you saying. can we not use a db as-is ? This may be pointless since you've already removed the files, but aren't the db files binaries distributed by upstream? That would violate bundling policies unless I'm missing something here. > For patch documenting, I have added comments to several issues i have opened > in the upstream project. Generally this project assumes it is built from > the amd rpms and has a lot of rough edges the older rocm projects have > smoothed off. So I feel the main problem is the upstream needs to try to > build on a second install location and they will understand and fix their > problems. Thanks, I appreciate it. Overall, it looks good to me. The only thing left in my mind is the details around how we include licensing text. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2261201 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202261201%23c14 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
