https://bugzilla.redhat.com/show_bug.cgi?id=2264218 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > > 3. You might want to validate the AppStream metadata with appstream as well, > > it is now used everywhere instead of appstream-glib (with one exception): > > > > ``` > > BuildRequires: appstream > > (...) > > appstreamcli validate --no-net path-to-file > > ``` > Will update, thanks I wrote *as well* because I suggested doing *both*. Using appstream-util from appstream-glib is still mandatory according to the Packaging Guidelines, even if that is no longer used by either GNOME Software or Plasma Discover. Please restore the appstream-util validation before importing the package. Other than that, package looks good to me now. You might also want to retire rust-helvum as soon as this package lands in f41 and f40. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2264218 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202264218%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
