https://bugzilla.redhat.com/show_bug.cgi?id=2253579 Arthur Bols <arthur@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(arthur@xxxxxxxx) | --- Comment #4 from Arthur Bols <arthur@xxxxxxxx> --- Sorry for the delay, I was on vacation. (In reply to Felix Wang from comment #2) > I am not very proficient in determining the correct license of the package. > Anyways, I give my viewpoint. I think the license may be LGPL-2.0-or-later > AND GPL-3.0-only. Can you explain clearly your thoughts on this? The license tag should be an enumeration of all licenses found in the source code (see https://docs.fedoraproject.org/en-US/legal/license-field/#_basic_rule ). A useful tool to determine this is licensecheck. You can see the breakdown in the PACKAGE-LICENSING file. (In reply to Dominik 'Rathann' Mierzejewski from comment #3) > (In reply to Felix Wang from comment #2) > > 1. license issue > > > > > # For a breakdown of the licensing, see PACKAGE-LICENSING > > > License: GPL-2.0-only AND GPL-3.0-only AND (GPL-3.0-only OR LGPL-2.1-only) > > > > > mv COPYING.LGPL-2 COPYING.GPL-2 # https://github.com/AyatanaIndicators/ayatana-ido/pull/68 > > I'd say it's: GPL-3.0-only AND (LGPL-3.0-only OR LGPL-2.1-only). > > Which files are GPL-2.0-only? The GPL-2.0-only is a remnant of me misinterpreting LGPL-2.0 as GPL-2.0... Thanks for noticing Felix and Dominik. `src/idotimeline.c` and `src/idotimeline.h` are LGPL-2.0-or-later. The correct license is thus "LGPL-2.0-or-later AND GPL-3.0-only AND (GPL-3.0-only OR LGPL-2.1-only)" I've updated the PACKAGE-LICENSING and spec file accordingly. PACKAGE-LICENSING file: https://principis.fedorapeople.org/libayatana-ido.PACKAGE-LICENSING (In reply to Dominik 'Rathann' Mierzejewski from comment #3) > (In reply to Felix Wang from comment #2) > > 2. enable the tests > > > > https://github.com/AyatanaIndicators/ayatana-ido/blob/main/CMakeLists.txt#L12 > > Enabling tests requires a bit more than just > BuildRequires: gtest-devel and %cmake -DENABLE_TESTS=ON > as they require a display and need to be run under Xvfb. Enabled the tests using Xvfb. Thanks for the suggestion! Spec URL: https://principis.fedorapeople.org/libayatana-ido.spec SRPM URL: https://principis.fedorapeople.org/libayatana-ido-0.10.1-1.fc39.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2253579 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202253579%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
