https://bugzilla.redhat.com/show_bug.cgi?id=2253579 Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(arthur@xxxxxxxx) --- Comment #3 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> --- (In reply to Felix Wang from comment #2) > 1. license issue > > > # For a breakdown of the licensing, see PACKAGE-LICENSING > > License: GPL-2.0-only AND GPL-3.0-only AND (GPL-3.0-only OR LGPL-2.1-only) > > > mv COPYING.LGPL-2 COPYING.GPL-2 # https://github.com/AyatanaIndicators/ayatana-ido/pull/68 > > I am not very proficient in determining the correct license of the package. > Anyways, I give my viewpoint. I think the license may be LGPL-2.0-or-later > AND GPL-3.0-only. Can you explain clearly your thoughts on this? I'd say it's: GPL-3.0-only AND (LGPL-3.0-only OR LGPL-2.1-only). Which files are GPL-2.0-only? > 2. enable the tests > > https://github.com/AyatanaIndicators/ayatana-ido/blob/main/CMakeLists.txt#L12 Enabling tests requires a bit more than just BuildRequires: gtest-devel and %cmake -DENABLE_TESTS=ON as they require a display and need to be run under Xvfb. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2253579 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202253579%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
