https://bugzilla.redhat.com/show_bug.cgi?id=2262452 --- Comment #8 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> --- FWIW once qbe was updated to a snapshot in rawhide and harec to 0.24.0-rc2 I looked at upgrading my own hare spec and I found a couple gotchas. https://github.com/dridi/dotfiles/commit/2c2b735a246ccc66029ebdc8f3d100e0e6a1ac39 I'm not sure why the test suite is not failing for you, but while it passes for me on f39, I needed to add a patch to make all tests pass on f40: https://git.sr.ht/~sircmpwn/hare/commit/6f3e0d3bdaeb318938cc5e05dfa40e3cad5b2db4 And it's not just test cases that would fail with the less robust leap-seconds.list parsing. Any Hare application working with time would be lacking actual leap seconds support. I submitted a patch to ensure that haredoc is built with the configured linker flags: https://lists.sr.ht/~sircmpwn/hare-dev/patches/49393 But I realize now that it will likely go through at least a second revision, because I forgot to add the Signed-off-by line to my patch. Anyway, once we fix the upstream Makefile and configure LDLINKFLAGS properly we can leave _missing_build_ids_terminate_build alone. In my spec file I solved it like this: https://github.com/dridi/dotfiles/blob/2c2b735a246ccc66029ebdc8f3d100e0e6a1ac39/rpmbuild/SPECS/hare.spec#L1-L9 We get the same flags as those from %{build_ldflags}, except hardening flags, which should be fine for the not-long-running-with-elevated-privileges haredoc program. I added the -z noexecstack as recommended by the Hare folks, but in hindsight, I should have applied this one in config.mk: LDFLAGS = %{build_ldflags} -Wl,-z,noexecstack LDLINKFLAGS = %{ldlinkflags} -z noexecstack Not what I did, but I will: https://github.com/dridi/dotfiles/blob/2c2b735a246ccc66029ebdc8f3d100e0e6a1ac39/rpmbuild/SPECS/hare.spec#L87-L88 This way we pass as many desired system-wide linker flags as possible and stay consistent with other packages. One could argue that we should add -R to HAREFLAGS in config.mk but I have not studied the concrete effect of this option (besides skipping the debug module). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2262452 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202262452%23c8 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
