https://bugzilla.redhat.com/show_bug.cgi?id=2263942 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx Flags| |fedora-review? --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Two small issues: - The project seems to contain a code copy-pasted / forked from tiny-http or rust-chunked-transfer, which is Apache-2.0-only. According to our legal guidelines, that means the license in metadata should be "(MIT OR Apache-2.0) AND Apache-2.0" instead of just "MIT OR Apache-2.0". - The crate includes a bunch of files that are unnecessary for packaging, and some that cause minor issues. For example, the shell scripts cause a dependency on /usr/bin/bash to be generated, which we don't want. Please exclude the unnecessary files (i.e. by adding something like `exclude = ["/cargo_deny.sh", "/deny.toml", "/test.sh"]` to the [package] table in Cargo.toml. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2263942 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202263942%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue