https://bugzilla.redhat.com/show_bug.cgi?id=2257727 --- Comment #10 from José Expósito <jexposit@xxxxxxxxxx> --- Hi Jiri, Thanks a lot for your review, I truly appreciate it. (In reply to Jiri Konecny from comment #9) > Hi Jose, > > a few points from the Python part. > > You should rename the package because Python guidelines requires naming in > form of python3-* instead of python postfix: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming > > To solve this you can do ``%files -n python3-gnome-ponytail-daemon`` and use > `-n` on other cases too. Solved, thanks! The generated RPM now is "python3-gnome-ponytail-daemon-0.0.10-1.fc39.noarch.rpm". > And you also need to add BuildRequires: python3-devel: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_buildrequire_python3_devel This one is already included, but using the "python3_pkgversion" macro: BuildRequires: python%{python3_pkgversion}-devel I have seen this definition in other packages, for example: https://src.fedoraproject.org/rpms/vulkan-tools/blob/rawhide/f/vulkan-tools.spec#_15 > Also you shouldn't have dependency on python3 instead the recommendation is: > > ``` > Packages SHOULD NOT have an explicit runtime dependency on python3. > > Instead of depending on python3, packages have an automatic dependency on > python(abi) = 3.X when they install files to %{python3_sitelib} or > %{python3_sitearch}, or they have an automatic dependency on > /usr/bin/python3 if they have executable Python scripts, or they have an > automatic dependency on libpython3.X.so.1.0() if they embed Python. > ``` > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_dependencies Good point, I removed the "Requires: python3". Also, even the documentation suggest that informing upstream is the only required action for the "incorrect-fsf-address" lint error, since my patch has been already merged, I included it in the package. Queuing a new build with your suggested changes. Thanks again for the review!! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2257727 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257727%23c10 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
