[Bug 2257727] Review Request: gnome-ponytail-daemon - A helper daemon intended for dogtail on Wayland

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2257727



--- Comment #9 from Jiri Konecny <jkonecny@xxxxxxxxxx> ---
Hi Jose,

a few points from the Python part.

You should rename the package because Python guidelines requires naming in form
of python3-* instead of python postfix:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_naming

To solve this you can do ``%files -n python3-gnome-ponytail-daemon`` and use
`-n` on other cases too.


And you also need to add BuildRequires: python3-devel:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_buildrequire_python3_devel


Also you shouldn't have dependency on python3 instead the recommendation is:

```
Packages SHOULD NOT have an explicit runtime dependency on python3.

Instead of depending on python3, packages have an automatic dependency on
python(abi) = 3.X when they install files to %{python3_sitelib} or
%{python3_sitearch}, or they have an automatic dependency on /usr/bin/python3
if they have executable Python scripts, or they have an automatic dependency on
libpython3.X.so.1.0() if they embed Python.
```
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2257727

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257727%23c9
--
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux