https://bugzilla.redhat.com/show_bug.cgi?id=2260598 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- First-pass review: 1. It looks like the "default" feature set builds only a "minimal" / "core" of tools that are supported everywhere. Looking at the list of things that are enabled by different features, it would be great if we could build with "unix" and "selinux" features enabled. The "unix" feature would enable a few more tools and more features for some tools that are already enabled as part of the "default" set. This would pull in a few more dependencies that are currently optional and disabled. The "selinux" feature would enable SELinux support for tools that are already part of the "default" set like uu_cp, uu_ls (and would not introduce additional dependencies - as far as I can tell by looking). 2. You might not want to build "uudoc" / enable the "uudoc" feature in the package. The feature only gets enabled by rust2rpm because the "uudoc" binary target requires it, but looking at what the "uudoc" binary does, I don't think it makes sense to actually ship that binary with the package (it seems to be a tool to generate some documentation, but that's more for upstream purposes, and not for users in Fedora). 3. It would be great if the man page and shell completions could be included in the package. 4. The list of skipped tests is pretty long, and there's no explanation for what's wrong with them other than "they mostly panic". It would be great if you could do at least *some* amount of investigation into why specific tests are failing - and document whether the failures have something to do with the build environment, or whether they are *actually* indicative of a real failure. === It's fine if you want to enable more tools / functionality *later* and get the package into Fedora as-is. However, it would be great if at least points 2 and 4 above could be addressed. As for point 1, I can help with doing package reviews for the missing uu_* tools that are currently disabled, but that is not a blocker for the review. For point 3, I can submit a PR once the package is imported, or you can add the manpages / shell completions to the package yourself later (building shell completions from the built binary works almost the same way in the "ruff" or "maturin" packages, for example). This would be nice-to-have, but it's not a blocker for the review either. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2260598 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202260598%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
