https://bugzilla.redhat.com/show_bug.cgi?id=2140723 Arthur Bols <arthur@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ Status|NEW |POST Doc Type|--- |If docs needed, set a value CC| |arthur@xxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |arthur@xxxxxxxx --- Comment #3 from Arthur Bols <arthur@xxxxxxxx> --- Package Review ============== Package was generated by go2rpm, which simplifies the review. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Missing -f flag on %gometa New packages should use this to exclude %ix86 Checks: ======= [x]: Spec file is sane. [x]: Latest version is packaged. [x]: License is correct and license file is included. [x]: %check is present and all tests pass. [x]: Package builds in mock. [x]: Package installs properly. [x]: rpmlint shows no relevant errors. There are many warnings about duplicate files, but these seem to be needed for testing, so can be ignored. [x]: Package does not generate any conflict. [x]: Package complies to the Packaging Guidelines Package APPROVED. Please fix the issue above before import. Post import tasks: - Add @go-sig with commit or admin access to the package - If possible, add your package to release-monitoring.org -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2140723 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202140723%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
