https://bugzilla.redhat.com/show_bug.cgi?id=2257076 --- Comment #7 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Fabio Valentini from comment #6) > Ok, first look at the package: > > 1. The LICENSE file is some weird JSON blob for, and it also doesn't match > what's downloaded from the URL: Oops! Yes, that’s definitely a URL typo. I’ll correct it. > 2. It looks like the dependencies on zstd / zstd-safe are actually > mismatched in upstream. > They should be zstd v0.13 to match with zstd-safe v7, *or* zstd v0.12 to > match with zstd-safe v6 - but not a weird mix older / newer versions of > these two crates. Thanks. I suggested this upstream, https://github.com/milesgranger/cramjam/pull/128. > 3. If you build the C library, you will get better generated spec file from > rust2rpm if the crate actually *defines* a cdylib target. Not sure why > upstream doesn't do this. > > Using "rust2rpm -p" to add this table to Cargo.toml should give you a better > template to start from: > > ``` > [lib] > crate-type = ["lib", "cdylib"] > ``` I tried that, and the template was indeed a *little* better – there was a %{crate} package for the C library – but I still had to add the cargo-c invocation, the %{crate}-devel package, and most of the other boilerplate. I could send a PR upstream, but I think I would need to be able to offer a better explanation of why they should care, i.e., how the change would do something useful in practice for them or their other users. It also occurred to me that none of the dependencies contribute to the binary RPM %{crate}-devel – nothing is bundled in the header file, the unversioned .so symlink, or the .pc file – so I don’t need to include the dependency licenses in the License field for that subpackage, only for %{crate}. I’ll change that as well. I’ll upload a new spec and SRPM after I double-check for major errors I might have made while changing things. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2257076 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257076%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
