https://bugzilla.redhat.com/show_bug.cgi?id=2257076 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Ok, first look at the package: 1. The LICENSE file is some weird JSON blob for, and it also doesn't match what's downloaded from the URL: Source checksums ---------------- https://github.com/milesgranger/cramjam/blob/8510678864af328a8b711f04ef2ddd8a4fa1d0cc/LICENSE : CHECKSUM(SHA256) this package : c382e6b2ecda2c387f070b758ebf97fd934310f1b3808e5aeb43c905779efdc4 CHECKSUM(SHA256) upstream package : a73b9239f0434299d723ac6454b3f66f9c4fb8c7889ee8309f98f7cd1131d4f4 https://crates.io/api/v1/crates/libcramjam/0.1.5/download#/libcramjam-0.1.5.crate : CHECKSUM(SHA256) this package : e1e4c9711efb07b28423df4f7e87235f2e5b927f379e515062f7f1b37ef55b12 CHECKSUM(SHA256) upstream package : e1e4c9711efb07b28423df4f7e87235f2e5b927f379e515062f7f1b37ef55b12 diff -r also reports differences Please fix - use the "raw" file link to get the actual file contents, not the "blob" link that gives you garbage: instead of https://github.com/milesgranger/cramjam/blob/8510678/LICENSE use https://github.com/milesgranger/cramjam/raw/8510678/LICENSE 2. It looks like the dependencies on zstd / zstd-safe are actually mismatched in upstream. They should be zstd v0.13 to match with zstd-safe v7, *or* zstd v0.12 to match with zstd-safe v6 - but not a weird mix older / newer versions of these two crates. 3. If you build the C library, you will get better generated spec file from rust2rpm if the crate actually *defines* a cdylib target. Not sure why upstream doesn't do this. Using "rust2rpm -p" to add this table to Cargo.toml should give you a better template to start from: ``` [lib] crate-type = ["lib", "cdylib"] ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2257076 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257076%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
