https://bugzilla.redhat.com/show_bug.cgi?id=2257190 --- Comment #2 from Michel Lind <michel@xxxxxxxxxxxxxxx> --- (In reply to Fabio Valentini from comment #1) > Three minor issues: > > 1. Not sure how this is possible, but the hash for the license file in your > SRPM does not match the hash for the license file downloaded from upstream. > You might want to reference a specific commit instead of "whatever is on top > of master right now" to prevent this from happening. > yeah, looks like upstream bumped the year in the copyright in https://github.com/koutheir/selinux/commit/2912ed0507b645988422fc401a19ebb2248b5621 > 2. Why is there a dependency on libacl-devel in this package? Uh, turns out I copied rust2rpm.toml from rust-exacl which of course requires libacl > 3. Upstream has released a new version (v0.4.3), please update if possible. Updated. This includes the license text so we're good there. I have to lower the serial_test dependency which is bumped in 0.4.3 to v3 (we only have v2), there are some breaking changes that it looks like upstream is not using yet. Spec URL: https://salimma.fedorapeople.org/rust-selinux.spec SRPM URL: https://salimma.fedorapeople.org/rust-selinux-0.4.3-1.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2257190 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257190%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
