https://bugzilla.redhat.com/show_bug.cgi?id=2257190 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? CC| |decathorpe@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Status|NEW |ASSIGNED --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Three minor issues: 1. Not sure how this is possible, but the hash for the license file in your SRPM does not match the hash for the license file downloaded from upstream. You might want to reference a specific commit instead of "whatever is on top of master right now" to prevent this from happening. 2. Why is there a dependency on libacl-devel in this package? If it's a test-only dependency, it should not be added as Requires: libacl-devel in the -devel subpackage. If it's a dependency of the selinux bindings, it should be added in the package for the selinux-sys crate instead. Since I cannot find any references to the string "acl" in the sources for this package, I assume the latter is the case. 3. Upstream has released a new version (v0.4.3), please update if possible. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2257190 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202257190%23c1 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
