https://bugzilla.redhat.com/show_bug.cgi?id=2229349 Tulio Magno Quites Machado Filho <tuliom@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tuliom@xxxxxxxxxx | |) | --- Comment #15 from Tulio Magno Quites Machado Filho <tuliom@xxxxxxxxxx> --- The spec looks good to me as is. Despite that, I have a few comments and questions that I hope will improve it further. By the way, I believe the previous comment should point to the SRPM at https://junghans.fedorapeople.org/lfortran-0.30.0-2.fc40.src.rpm > ExclusiveArch: x86_64 AFAICS, lfortran does support aarch64. Any reasons to restrict to x86_64? Besides that, should WITH_TARGET_AARCH64 and WITH_TARGET_WASM also be enabled in all builds? This is what I'm seeing right now: WITH_TARGET_AARCH64: no WITH_TARGET_X86: yes WITH_TARGET_WASM: no > BuildRequires: llvm16-devel Does lfortran support LLVM 17? If it does, I suggest to move to this version. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2229349 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202229349%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
