https://bugzilla.redhat.com/show_bug.cgi?id=2251086 --- Comment #25 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 76 files have unknown license. Detailed output of licensecheck in /home/fedora/2251086-rocfft/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3703 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rocfft-6.0.0-1.fc40.x86_64.rpm rocfft-devel-6.0.0-1.fc40.x86_64.rpm rocfft-test-6.0.0-1.fc40.x86_64.rpm rocfft-debuginfo-6.0.0-1.fc40.x86_64.rpm rocfft-debugsource-6.0.0-1.fc40.x86_64.rpm rocfft-6.0.0-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_xin4ora')] checks: 32, packages: 6 rocfft.spec: E: specfile-error sed: -e expression #2, char 44: unterminated `s' command rocfft-test.x86_64: W: position-independent-executable-suggested /usr/bin/rocfft-test rocfft-test.x86_64: W: position-independent-executable-suggested /usr/bin/rtc_helper_crash rocfft-test.x86_64: W: no-manual-page-for-binary rocfft-test rocfft-test.x86_64: W: no-manual-page-for-binary rtc_helper_crash rocfft-devel.x86_64: W: no-documentation rocfft-test.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 1 errors, 6 warnings, 38 filtered, 1 badness; has taken 2.0 s Rpmlint (debuginfo) ------------------- Checking: rocfft-debuginfo-6.0.0-1.fc40.x86_64.rpm rocfft-test-debuginfo-6.0.0-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp88y4zbyh')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 22 filtered, 0 badness; has taken 1.0 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 6 rocfft-test.x86_64: W: position-independent-executable-suggested /usr/bin/rocfft-test rocfft-test.x86_64: W: position-independent-executable-suggested /usr/bin/rtc_helper_crash rocfft-test.x86_64: W: no-manual-page-for-binary rocfft-test rocfft-test.x86_64: W: no-manual-page-for-binary rtc_helper_crash rocfft-devel.x86_64: W: no-documentation rocfft-test.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 6 warnings, 47 filtered, 0 badness; has taken 1.8 s Source checksums ---------------- https://github.com/ROCmSoftwarePlatform/rocFFT/archive/rocm-6.0.0.tar.gz#/rocFFT-rocm-6.0.0.tar.gz : CHECKSUM(SHA256) this package : fb8ba56572702e77e4383d922cd1fee4ad3fa5f63a5ebdb3d9c354439a446992 CHECKSUM(SHA256) upstream package : fb8ba56572702e77e4383d922cd1fee4ad3fa5f63a5ebdb3d9c354439a446992 Requires -------- rocfft (rpmlib, GLIBC filtered): ld-linux-x86-64.so.2()(64bit) libamdhip64.so.6()(64bit) libamdhip64.so.6(hip_4.2)(64bit) libamdhip64.so.6(hip_6.0)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) rocfft-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) librocfft.so.0()(64bit) rocfft(x86-64) rocfft-test (rpmlib, GLIBC filtered): libamdhip64.so.6()(64bit) libamdhip64.so.6(hip_4.2)(64bit) libamdhip64.so.6(hip_4.3)(64bit) libamdhip64.so.6(hip_6.0)(64bit) libboost_program_options.so.1.81.0()(64bit) libc.so.6()(64bit) libfftw3.so.3()(64bit) libfftw3_omp.so.3()(64bit) libfftw3f.so.3()(64bit) libfftw3f_omp.so.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgtest.so.1.14.0()(64bit) libm.so.6()(64bit) libomp.so()(64bit) libomp.so(VERSION)(64bit) librocfft.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) rocfft(x86-64) rtld(GNU_HASH) rocfft-debuginfo (rpmlib, GLIBC filtered): rocfft-debugsource (rpmlib, GLIBC filtered): Provides -------- rocfft: librocfft.so.0()(64bit) rocfft rocfft(x86-64) rocfft-devel: cmake(rocfft) rocfft-devel rocfft-devel(x86-64) rocfft-test: rocfft-test rocfft-test(x86-64) rocfft-debuginfo: debuginfo(build-id) librocfft.so.0.1-6.0.0-1.fc40.x86_64.debug()(64bit) rocfft-debuginfo rocfft-debuginfo(x86-64) rocfft-debugsource: rocfft-debugsource rocfft-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2251086 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Ocaml, Perl, Python, PHP, Haskell, fonts, SugarActivity, R, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) For the url field consider using either: https://github.com/ROCm/rocFFT or https://github.com/ROCm/%{upstreamname} The repository https://github.com/ROCmSoftwarePlatform/rocFFT does not exist. b) The file CMakeLists.txt contains set ( VERSION_STRING "1.0.23" ), but website indicates version 1.0.25 - which is correct? Raised issue upstream https://github.com/ROCm/rocFFT/issues/453 c) Using %exclude %{_docdir}/%{name}/LICENSE.md is discouraged It is better to remove the extra installed copy of the license file after the install step like is done for client_info file and helper_binary d) There is a possibility to build samples and benchmarks, could some of these be used as smoke tests? e) Can your patches for GNUInstallDirs and rpath removal be upstreamed? Having them as options may be useful elsewhere and will make maintenance easier. f) Is it possible to add -pie flags to remove the warnings: rocfft-test.x86_64: W: position-independent-executable-suggested /usr/bin/rocfft-test rocfft-test.x86_64: W: position-independent-executable-suggested /usr/bin/rtc_helper_crash g) Can the documentation be built? Ideally as man pages. Some additional dependencies such as python3dist(sphinx) are needed as is packaging of https://github.com/RadeonOpenCompute/rocm-docs-core. Initially may want to just package the files in docs/samples -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2251086 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251086%23c25 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
