https://bugzilla.redhat.com/show_bug.cgi?id=2249418 --- Comment #20 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- >> Comments: >> a) Builds on all architectures: >> https://koji.fedoraproject.org/koji/taskinfo?taskID=109664151 >I don’t understand the comment – it builds on all arches, doesn’t it? Just showing that it did. Not all comments are negative feedback. >> b) Please remove patch to update FSF address, should not change license >> files distributed with the software, >> just let upstream know about it, if the accept your pull request, can >> include changes in the next version. >I can’t find anything in the Packaging Guidelines indicating that updating the FSF address in copies of the GPL is out of bounds. >After all, this change doesn’t modify the licensing conditions and helps users who want to get a copy of the license from the FSF. Will need to look up where this is. The only requirement is to report that the address is outdated. Modifying the license from what upstream provides is not good practice. >> c) Please also create a pull request upstream for LGPL license, the contact >I don’t understand, I did this already: >--- 8< --- ># https://github.com/jackaudio/jack-example-tools/pull/84 >Patch: 0001-Add-LGPL-v2.1-license-text.patch >--- >8 --- >> author for that file seems to be active: >> https://github.com/pauldavisthefirst >Paul last contributed to this in 2012, while it still was part of the jack code base itself. I think he’s moved on from working on >JACK. FalkTX who worked on this last seems to occasionally commit changes, but my PRs are still untouched. Ok, sorry, missed this. >> Maybe it should be GPL like all the others? >The LGPL is a different license, I don’t see why we should do that. Just an observation that the license differed, not sure if it is an error upstream. Would have expected one set of licenses. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2249418 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249418%23c20 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
