https://bugzilla.redhat.com/show_bug.cgi?id=2255786 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to Sandro from comment #2) > My first thought glancing over the spec file: > > > # We use the GitHub archive instead of the PyPI sdist to get CHANGELOG.md and > > # the tests. > > Source: %{url}/archive/%{version}/argparse_dataclass-%{version}.tar.gz > > Doesn't that scream `%forgesource`, pretty please with sugar on top? You know, I personally find that it’s not worth defining %forgeurl and adding %forgemeta just to simplify the source URL and avoid writing out the extraction directory name for %autosetup. There is just as much noise added to the spec file as is removed, and at the cost of an extra layer of indirection. I do find the forge macros can be worth it for forges with much less straightforward URL schemes (GitLab), and perhaps when frequently alternating between snapshots and proper releases. I’m not opposed to the general NeuroFedora habit of adding forge macros or to working on packages that use them. I just don’t *personally* find that they add much in straightforward cases like this. > It would also let you do away with `%autosetup -n > argparse_dataclass-%{version}` in favor of `%forgeautosetup`. On the other hand, considering the comments in https://git.sr.ht/~gotmax23/forge-srpm-macros/tree/354ce4a51e80f6d524084d49612d77e69336cb71/item/rpm/macros.d/macros.forge#L65 about possibly removing %forgeautosetup in the future, this is probably better written as %autosetup %{forgesetupargs} -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2255786 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255786%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
