https://bugzilla.redhat.com/show_bug.cgi?id=2255786 Sandro <gui1ty@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gui1ty@xxxxxxxxxxxxx --- Comment #2 from Sandro <gui1ty@xxxxxxxxxxxxx> --- My first thought glancing over the spec file: > # We use the GitHub archive instead of the PyPI sdist to get CHANGELOG.md and > # the tests. > Source: %{url}/archive/%{version}/argparse_dataclass-%{version}.tar.gz Doesn't that scream `%forgesource`, pretty please with sugar on top? It would also let you do away with `%autosetup -n argparse_dataclass-%{version}` in favor of `%forgeautosetup`. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2255786 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202255786%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue