Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sectool - A security audit system and intrusion detection system https://bugzilla.redhat.com/show_bug.cgi?id=428823 ------- Additional Comments From mitr@xxxxxxxxxx 2008-01-15 17:23 EST ------- * rpmlint output: > sectool.noarch: E: non-executable-script /usr/share/sectool/scheduler/scheduler.py 0644 > sectool.noarch: E: non-executable-script /usr/share/sectool/actions.py 0644 > sectool.noarch: E: non-executable-script /usr/share/sectool/scheduler/__init__.py 0644 > sectool.noarch: E: non-executable-script /usr/share/sectool/scheduler/i18n.py 0644 > sectool.noarch: E: non-executable-script /usr/share/sectool/output.py 0644 > sectool.noarch: E: non-executable-script /usr/share/sectool/__init__.py 0644 > sectool.noarch: E: non-executable-script /usr/share/sectool/tuierrors.py 0644 > sectool.noarch: E: non-executable-script /usr/share/sectool/scheduler/errors.py 0644 Need fixing (by removing the #!... line) > sectool.noarch: E: non-executable-script /usr/share/sectool/scheduler/selftest.py 0644 Needs fixing (make it executable, or don't ship it) > sectool.noarch: E: non-standard-executable-perm /usr/share/sectool/tests/netserv.sh 0744 > sectool.noarch: E: non-standard-executable-perm /usr/share/sectool/tests/home_dirs.sh 0744 > sectool.noarch: E: non-standard-executable-perm /usr/share/sectool/tests/selftest.sh 0744 > sectool.noarch: E: non-standard-executable-perm /usr/share/sectool/tests/disc_usage.sh 0744 > sectool.noarch: E: non-standard-executable-perm /usr/share/sectool/tests/suid.py 0744 > sectool.noarch: E: non-standard-executable-perm /usr/share/sectool/sectool.py 0744 > sectool.noarch: E: non-standard-executable-perm /usr/share/sectool/tests/path.sh 0744 > sectool.noarch: E: non-standard-executable-perm /usr/share/sectool/tests/home_files.sh 0744 > sectool.noarch: E: non-standard-executable-perm /usr/share/sectool/tests/passwd.sh 0744 Need fixing - use 0755 > sectool.noarch: W: symlink-should-be-relative /usr/bin/sectool /usr/share/sectool/sectool.py Fixing this is not quite necessary IMHO, but it can't hurt. > sectool.noarch: E: non-standard-executable-perm /usr/share/sectool/tests/python_defs.py 0744 Needs fixing - use 0644 > sectool.noarch: W: incoherent-version-in-changelog 0.1.0 0.1.0-1.fc8 Use "0.1.0-1" in the %changelog version number > sectool.noarch: W: dangerous-command-in-%post rm > sectool.noarch: W: bogus-variable-use-in-%post $RPM_BUILD_ROOT Definitely needs fixing: * $RPM_BUILD_ROOT is no longer relevant in %post * Why does that script remove the .py[co] files anyway? > sectool-gui.noarch: W: no-documentation OK > sectool-gui.noarch: E: script-without-shebang /etc/security/console.apps/sectool-gui > sectool-gui.noarch: E: script-without-shebang /etc/pam.d/sectool-gui These files should not be executable. > sectool-gui.noarch: E: non-executable-script /usr/share/sectool/guiOutput.py 0644 > sectool-gui.noarch: E: non-executable-script /usr/share/sectool/guiRender.py 0644 Remove the #!... line. > sectool-gui.noarch: E: non-standard-executable-perm /usr/share/sectool/sectool-gui.py 0744 Use 0755 > sectool-gui.noarch: W: no-dependency-on usermode Needs fixing > sectool-gui.noarch: W: spelling-error-in-description extention extension Needs fixing -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review