Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: MyBashBurn - burn data and songs. Alias: MyBashBurn https://bugzilla.redhat.com/show_bug.cgi?id=217197 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-01-15 17:20 EST ------- It seems to me that the tarball in the srpm is not the same as the upstream tarball. Looking at the MyBashBurn.sh file, it's clear that the license should be GPLv2+ as they allow "any later version". I believe those are the only issues remaining. To refresh my memory, let me run through my checklist again: X source files do not match upstream. * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. description is OK. dist tag is present. build root is OK. X license field matches the actual license (should be GPLv2+) * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper (none) * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: mybashburn = 1.0.2-3.fc9 = /bin/sh /usr/bin/env cdda2wav cdrdao cdrecord coreutils dialog >= 1.0 dvd+rw-tools eject flac mkisofs vorbis-tools * %check is not present; no test suite upstream. I did some light testing (over the network so I didn't actually try to burn anything) and it seems to work OK. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review