https://bugzilla.redhat.com/show_bug.cgi?id=2251086 --- Comment #6 from Tom Rix <trix@xxxxxxxxxx> --- For Ben's question about %check Checking depends on having an AMD GPU in the build machine, that is not possible. The -test subpackage is consistent with how other rocm packages have handled this. However in the other packages -test is off by default and not expected to be part of the offical fedora release. We should be consistent, can rocfft also have -test off by default ? New comments CMAKE_BUILD_TYPE=Debug We have not figured out how or if to do this. I know from my own experiments that this will cause packing errors when the rpm tooling does not handle some clang-ism. And if we did have a -debug, I would not want to *-d.so lib names. Above, I also changed the RELEASE to RelWithDebInfo so it would be consistent with other packages. The explicit list of AMDGPU_TARGETS is missing some, you can see in the cmake output that gfx94x is checked. If we need a full list, I think it would be useful to add that to rocm-rpm-macros package macros.rocm file. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2251086 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251086%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
