https://bugzilla.redhat.com/show_bug.cgi?id=2251086 --- Comment #5 from Tom Rix <trix@xxxxxxxxxx> --- some changes to use the rocm toolchaindiff --git a/rocfft.spec b/rocfft.spec index 64ade62..7956e76 100644 --- a/rocfft.spec +++ b/rocfft.spec @@ -7,11 +7,9 @@ # rocFFT has a version seperate from the ROCm version that it is released with %global rocfft_version 1.0.23 -# Compiler is hipcc, which is clang based: -%global toolchain clang - -#The target doesn't support -fcf-protection: -%global optflags %(o="%{optflags}"; echo ${o//-fcf-protection/}) +%global toolchain rocm +# hipcc does not support some clang flags +%global build_cxxflags %(echo %{optflags} | sed -e 's/-fstack-protector-strong/-Xarch_host -fstack-protector-strong/' -e 's/-fcf-protection/-Xarch_host -fcf-protection/') # the debug build has a completely different file name, use condition to enable/disable %bcond rocm-debug 0 @@ -53,6 +51,7 @@ BuildRequires: llvm-devel BuildRequires: rocm-cmake BuildRequires: rocm-comgr-devel BuildRequires: rocm-hip-devel +BuildRequires: rocm-rpm-macros BuildRequires: rocm-runtime-devel BuildRequires: sqlite-devel @@ -107,15 +106,13 @@ self tests for the rocfft library %if %{with rocm-debug} -DCMAKE_BUILD_TYPE=Debug \ %else - -DCMAKE_BUILD_TYPE=Release \ + -DCMAKE_BUILD_TYPE=RelWithDebInfo \ %endif %if %{with kernelcache} -DROCFFT_KERNEL_CACHE_ENABLE=ON \ %else -DROCFFT_KERNEL_CACHE_ENABLE=OFF \ %endif - -DCMAKE_CXX_COMPILER=hipcc \ - -DCMAKE_C_COMPILER=hipcc \ -DAMDGPU_TARGETS="gfx803;gfx900;gfx906;gfx908;gfx90a;gfx1030;gfx1100;gfx1101;gfx1102" \ -DBUILD_FILE_REORG_BACKWARD_COMPATIBILITY=OFF \ -DSQLITE_USE_SYSTEM_PACKAGE=ON \ -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2251086 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251086%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue