https://bugzilla.redhat.com/show_bug.cgi?id=2247585 --- Comment #5 from Frank Dedden <frank@xxxxxxxxxxx> --- Thanks for the response. > > - If your application is a C or C++ application you must list a > > BuildRequires against gcc, gcc-c++ or clang. > > Note: No gcc, gcc-c++ or clang found in BuildRequires > > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ > > I think this is okay since ghc is used. Yes, that is what I thought. > > - Changelog not in correct format. > > Could you elaborate? Ah now I see, the changelog in the .spec does match (https://docs.fedoraproject.org/en-US/packaging-guidelines/manual-changelog/), but the changelog of the Haskell package doesn't. Obviously the one from the .spec is meant to match the format. > > - No debuginfo package, nor a justification. > > Currently debuginfo is disabled for Haskell, because it is generally not > useful. OK. > > - Package only available for x86_64. > > Not sure what you mean: the Koji builds should cover all our architectures. > :) > The reference copr builds are only for x86_64 I think that is correct. I see, the Koji build indeed has the other architectures too. > > - No %check section in .spec. > > I don't think there are any tests for this library. OK, so we just ignore this requirement? > > ===== MUST items ===== > > [?]: Development (unversioned) .so files in -devel subpackage, if present. > > Note: Unversioned so-files in private %_libdir subdirectory (see > > attachment). Verify they are not in ld path. > > I think this is known/expected for Haskell > > > [?]: Packages should try to preserve timestamps of original installed > > files. > > I think this probably okay - also major artifacts are rebuilt anyway. OK. I'll adjust review accordingly. Please let know if there's anything else to do. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2247585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202247585%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
