https://bugzilla.redhat.com/show_bug.cgi?id=2247585 --- Comment #4 from Jens Petersen <petersen@xxxxxxxxxx> --- Thanks for reviewing - some comments below inline (In reply to Frank Dedden from comment #2) > - If your application is a C or C++ application you must list a > BuildRequires against gcc, gcc-c++ or clang. > Note: No gcc, gcc-c++ or clang found in BuildRequires > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ I think this is okay since ghc is used. > - Changelog not in correct format. Could you elaborate? > - No debuginfo package, nor a justification. Currently debuginfo is disabled for Haskell, because it is generally not useful. > - Package only available for x86_64. Not sure what you mean: the Koji builds should cover all our architectures. :) The reference copr builds are only for x86_64 I think that is correct. > - No %check section in .spec. I don't think there are any tests for this library. > ===== MUST items ===== > [?]: Development (unversioned) .so files in -devel subpackage, if present. > Note: Unversioned so-files in private %_libdir subdirectory (see > attachment). Verify they are not in ld path. I think this is known/expected for Haskell > [?]: Packages should try to preserve timestamps of original installed > files. I think this probably okay - also major artifacts are rebuilt anyway. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2247585 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202247585%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
