https://bugzilla.redhat.com/show_bug.cgi?id=2249863 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > I’m trying to understand why additional patching would be needed; we can be certain the bundled liblz4 is not used because it is removed in %prep. It's not strictly necessary in this case. Though I would not patch in a "static" feature that will never (and can never) be used. A case where an additional patch was helpful is here: https://src.fedoraproject.org/rpms/rust-pq-sys/blob/rawhide/f/0001-Unconditionally-use-pkg-config-to-link-against-syste.patch In that case, the pkgconfig code path is used unconditionally, regardless of feature flags passed to the build. That makes it unnecessary to patch dependent packages. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2249863 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249863%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
