https://bugzilla.redhat.com/show_bug.cgi?id=2249863 --- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- (In reply to blinxen from comment #2) > I took a quick peek at the package > > * There are no license files being installed here, probably because the > crate is published without them. > I normally submit a PR upstream that adds the license file. Looking at > upstream here, a simple "cd lz4-sys && ln -s ../LICENSE" should do the trick > here. > To get this reviewed in the meantime, you can just add the license file > manually and remove it later once your PR has been merged and released. Good catch, and good suggestion. I made a PR, https://github.com/10XGenomics/lz4-rs/pull/40, and I will add the appropriate LICENSE file as an additional source. > * Your patch for using the system library looks good. Some comments: > * Consider adding ".print_system_libs(false)" to the pkg-config patch to > prevent linking errors for consumers This seems reasonable, although I am not sure I understand how an extra “-L/usr/lib64” or similar would break anything. I’ll update my PR. If this is really a problem, it probably needs to be fixed in https://github.com/alexcrichton/bzip2-rs/blob/master/bzip2-sys/build.rs as well. > * For Fedora you should force the usage of the system library, since this > is the only way we want to link against "libz" > Here is an example of how to do it: > https://src.fedoraproject.org/rpms/rust-libz-sys/blob/rawhide/f/0001- > unconditionally-use-pkg-config-to-link-with-system-z.patch I’m trying to understand why additional patching would be needed; we can be certain the bundled liblz4 is not used because it is removed in %prep. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2249863 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202249863%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
