https://bugzilla.redhat.com/show_bug.cgi?id=2251579 --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to blinxen from comment #5) > I took a little peek and want to add the following comments: > > - The `rustup` binary can generate shell completions [1], would be cool if > you can generate them after the binary is built and add them to the package I can try to do that, but see next point. > - The binary name seems to be `rustup-init`, can this be renamed to `rustup`? No, they are different things. rustup-init is the program that sets up rustup for the user, but it's not rustup itself. However, I *think* the binary is the same, and if I just make a temporary copy of rustup-init as rustup I might be able to generate the shell completions. > - Tracing support has been patched out, I guess packaging `rs_tracing` > brings in another batch of deps? It does - and if it's disabled, all the tracing support compiles down to noops. I'd rather not package a tracing stack that will end up unused. > - In `www/fonts/` there is a "SIL OPEN FONT" license, however I am unsure if > the fonts are used for the doc generation or if this is just for the > official rustup page. The "www" directory contains the sources for https://rustup.rs/ (see "index.html" file). None of those files should end up in the compiled "rustup-init" binary. > [1] > https://rust-lang.github.io/rustup/installation/index.html#enable-tab- > completion-for-bash-fish-zsh-or-powershell -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2251579 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251579%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
