https://bugzilla.redhat.com/show_bug.cgi?id=2251579 blinxen <h-k-81@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(leo@xxxxxxxxxxxx) --- Comment #5 from blinxen <h-k-81@xxxxxxxxxxx> --- I took a little peek and want to add the following comments: - The `rustup` binary can generate shell completions [1], would be cool if you can generate them after the binary is built and add them to the package - The binary name seems to be `rustup-init`, can this be renamed to `rustup`? - Tracing support has been patched out, I guess packaging `rs_tracing` brings in another batch of deps? - In `www/fonts/` there is a "SIL OPEN FONT" license, however I am unsure if the fonts are used for the doc generation or if this is just for the official rustup page. [1] https://rust-lang.github.io/rustup/installation/index.html#enable-tab-completion-for-bash-fish-zsh-or-powershell Here is a also copr build with a FedoraReview template: https://copr.fedorainfracloud.org/coprs/blinxen/fedora-review-rustup/build/6700149/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2251579 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251579%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
