https://bugzilla.redhat.com/show_bug.cgi?id=2248164 --- Comment #5 from Davide Cavalca <davide@xxxxxxxxxxxx> --- > speakersafetyd is not directly related to this package (yet?) and technically optional (you actually get usable volume without it, just not loud) so it probably doesn't make sense as a hard dep. Recommends? Yep, Recommends seems appropriate then > PS: While I generally agree that the %forge macros are definitely not needed in a simple case like this, they *are* being actively maintained again. So for more complicated packages (like packages with multiple sources that are all git snapshots or something), they are definitely a good choice. But here, you don't gain anything by using them except additional indirection. Ah, good to know, thanks. Last I checked they were generating version strings that didn't match the latest policy guidelines, so I stopped using them. I'll have to check them out again. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2248164 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202248164%23c5 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
