https://bugzilla.redhat.com/show_bug.cgi?id=2248164 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |decathorpe@xxxxxxxxx --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Davide Cavalca from comment #2) > Some quick feedback: > > - don't use the forge macros, they're not in great shape and aren't actually > needed here; just do something like > URL: https://github.com/AsahiLinux/asahi-audio > Source: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz > - should we also require speakersafetyd? > - add %doc README.md to the %files section to get it included PS: While I generally agree that the %forge macros are definitely not needed in a simple case like this, they *are* being actively maintained again. So for more complicated packages (like packages with multiple sources that are all git snapshots or something), they are definitely a good choice. But here, you don't gain anything by using them except additional indirection. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2248164 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202248164%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
