https://bugzilla.redhat.com/show_bug.cgi?id=2246561 --- Comment #16 from Fabio Valentini <decathorpe@xxxxxxxxx> --- A few minor things for now (still going over the package): 1. Looks like there's a file "/usr/share/licenses/helix/LICENSE-tree-sitter-." getting installed, this looks like a mistake? 2. It seems that the grammar plugins that are getting compiled with "cc" link libm and libgcc_s even if they don't have to: helix.x86_64: W: unused-direct-shlib-dependency /usr/lib64/helix/runtime/grammars/astro.so /lib64/libm.so.6 helix.x86_64: W: unused-direct-shlib-dependency /usr/lib64/helix/runtime/grammars/astro.so /lib64/libgcc_s.so.1 This might or might not be a false positive - but usually plugins don't need to be linked against libraries directly, as the "host" program that loads the plugins is expected to do that. But since the "host" program is Rust here ... not sure about that. helix *does* link against both libm.so and libgcc_s.so, so it should be fine if the plugins didn't do that themselves - but I'm not sure the "cc" crate can be configured to compile objects like that. So I don't consider this to be a blocker, just a warning for you (or maybe upstream). 3. There appear to be some files that have executable permissions that should not have them: helix.x86_64: E: script-without-shebang /usr/share/licenses/helix/LICENSE-tree-sitter-svelte 4. These shell completion scripts have shebangs but don't need them (I think)? helix.x86_64: E: non-executable-script /usr/share/bash-completion/completions/hx 644 /usr/bin/env bash helix.x86_64: E: non-executable-script /usr/share/fish/vendor_completions.d/hx.fish 644 /usr/bin/env fish -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2246561 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246561%23c16 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
