https://bugzilla.redhat.com/show_bug.cgi?id=2246561 --- Comment #15 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to blinxen from comment #12) > > Yes. The themes are getting installed, so the associated license file(s) should get installed too. > > Theme license files are now being manually installed (The PR for the license > files has been merged upstream :D). Great, thanks! > > For example, do something like "cp -p runtime/grammars/foo/LICENSE -> LICENSE-tree-sitter-foo" for all grammar modules, and then do "%license LICENSE-tree-sitter-*" in %files. > > This was a bit tricky. There are some grammars that already contained > license files but helix uses an older version (commit SHA) for them, so the > files are missing. I manually added those and created > https://github.com/helix-editor/helix/pull/8691. Thanks! > There is a small subset of > grammars that doesn't have license files. I filed PRs for them and manually > added the license files from my forks. I hope that is OK. It's OK in the short-term, but please switch back to upstream sources as soon as the projects merge your PRs. > Since helix uses commits SHAs to download the grammars from GitHub, I can't > really define a version for the bundled provides so I omitted that (should > be OK according to the packaging guidelines). It's OK, but I think you might be able to use pseudo-snapshot versioning. For example, if the snapshot for commit 1a2b3cd happened after version 1.2.3 was released, you could add something like "Provides: bundled(...) = 1.2.3^git1a2b3cd". That would make identifying the versions a little bit easier, but it's not required by the guidelines, so I won't require it either. :) > Here are the updated files: > Spec URL: https://blinxen.fedorapeople.org/helix/helix.spec > SRPM URL: https://blinxen.fedorapeople.org/helix/helix-23.10-1.fc40.src.rpm Thanks! I'll do a full review now. PS: I might ask somebody else for a second opinion later since this is a rather complicated package with many components, and I'm not sure I'm getting 100% of the things right here. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2246561 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246561%23c15 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
