https://bugzilla.redhat.com/show_bug.cgi?id=2246561 --- Comment #9 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to blinxen from comment #8) > > Yes - the MIT license requires license text to be included with distributed sources. > > I will look into this and create a PR upstream. Great, thanks! > > However, not all included tree-sitter grammars ship their own license files, which might be a problem for redistributing them. > > Did you check this manually? Do you have an example grammar? I just did a spot-check, and the lexicographically first one already doesn't contain a license file (tree-sitter-astro, in runtime/grammars/sources/astro). There are others that are missing license files as well. > > I also noticed that some grammars require "tree-sitter = 0.19", which is an unsatisfiable dependency in Fedora - are those grammars just not built? > > Hm, yeah that's weird. They are built but I am unsure how. Will have to > investigate how this actually works. See > https://blinxen.fedorapeople.org/helix/tree-sitter-versions-unique for all > `tree-sitter` versions that are used. I think I know what's happening. Those grammars are built as C objects by the helix build scripts, not as Rust projects. So the dependencies specified in Cargo.toml don't even factor into it, from what I can tell. It also looks like the "tree-sitter-afl-fuzzer" (the only crate that has more than just the "tree-sitter" crate dependency) is not an actual tree-sitter grammar, but a subproject of the SSH client configuration grammar, so it isn't used at all. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2246561 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246561%23c9 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
