https://bugzilla.redhat.com/show_bug.cgi?id=2246561 --- Comment #8 from blinxen <h-k-81@xxxxxxxxxxx> --- > Yes - the MIT license requires license text to be included with distributed sources. I will look into this and create a PR upstream. > I meant the contents of the "runtime/grammars/sources/hcl/example/" directory. Ah, yeah they are not used during compilation. This can be checked by grepping (`rg example --glob='!example' --glob='!.git'`) the source. > I don't think unbundling all the tree-sitter grammars as separate projects (163 projects?) would be a reasonable solution, so building them from the bundled sources is OK. However, they will need to be specified as bundled dependencies, and their licenses taken into account in the License tag for the package. :+1: > I'm not sure how to best deal with the licenses for all the tree sitter grammars - it looks like they all only depend on the "tree-sitter" crate that provides bindings for the tree-sitter C library, but I haven't checked *all of them* if they also depend on other Rust crates I created a file (https://blinxen.fedorapeople.org/helix/cargo_toml_of_grammars.toml) that contains all `Cargo.toml` files of all grammars. There is only one crate that requires other dependencies than `tree-sitter`. The additional dependencies are `encoding_rs` and `encoding_rs_io`. Both licenses should be covered in the package license tag. > But at least the tree-sitter crate is already a dependency of helix-core, so it's already taken into account by the %cargo_license macro. :+1: > However, not all included tree-sitter grammars ship their own license files, which might be a problem for redistributing them. Did you check this manually? Do you have an example grammar? > I also noticed that some grammars require "tree-sitter = 0.19", which is an unsatisfiable dependency in Fedora - are those grammars just not built? Hm, yeah that's weird. They are built but I am unsure how. Will have to investigate how this actually works. See https://blinxen.fedorapeople.org/helix/tree-sitter-versions-unique for all `tree-sitter` versions that are used. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2246561 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202246561%23c8 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
