[Bug 2241432] Review Request: python-pycomposefile - Structured deserialization of Docker Compose files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2241432



--- Comment #5 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
--- srpm-unpacked/python-pycomposefile.spec     2023-09-28 20:00:00.000000000
-0400   
+++ python-pycomposefile.spec   2023-10-26 11:24:46.293124109 -0400
@@ -9,11 +9,15 @@

 License:        MIT
 URL:            https://github.com/smurawski/pycomposefile
-Source:         %{pypi_source %{srcname}}
+Source:         %{url}/archive/v%{version}/%{srcname}-%{version}.tar.gz

 # Added a PR to make a license file in the repository.
 # https://github.com/smurawski/pycomposefile/pull/27
-Source1:       
https://patch-diff.githubusercontent.com/raw/smurawski/pycomposefile/pull/27.patch
+Patch:          %{url}/pull/27.patch
+
+# Remove src from test import
+# https://github.com/smurawski/pycomposefile/pull/30
+Patch:          %{url}/pull/30.patch

 BuildArch:      noarch
 BuildRequires:  python3-devel
@@ -36,18 +40,25 @@

 %prep
 %autosetup -p1 -n %{srcname}-%{version}
-cp %{SOURCE1} .

 %generate_buildrequires
+# Work around an upstream bug with the version number.
+# https://github.com/smurawski/pycomposefile/issues/29
+export BUILD_TAG='%{version}'
+cd src/
 %pyproject_buildrequires


 %build
+export BUILD_TAG='%{version}'
+cd src/
 %pyproject_wheel


 %install
+export BUILD_TAG='%{version}'
+cd src/
 %pyproject_install

 # Remove the installed tests.
@@ -57,26 +68,17 @@


 %check
-%pyproject_check_import -e tests.service.test_service_environment
+%pyproject_check_import

 %if %{with tests}
-
-# Some test files refer to ./src instead of ./pycomposefile.
-sed 's/src.pycomposefile/pycomposefile/' -i tests/**/*.py
-
-%pytest -k "\
-    not test_service_with_list_environment_file \
-    and not test_service_with_resolved_environment_variables \
-    and not test_service_with_single_environment_file \
-    and not test_service_with_long_syntax \
-    and not test_service_with_single_secret"
-
+%pytest
 %endif


 %files -n python3-%{srcname} -f %{pyproject_files}
 %doc README.md
+%license LICENSE


 %changelog
-%autochangelog
\ No newline at end of file
+%autochangelog


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2241432

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241432%23c5
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux