https://bugzilla.redhat.com/show_bug.cgi?id=2244729 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #10 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > Source: http://loop-aes.sourceforge.net/aespipe/aespipe-v%{version}.tar.bz2 This can be simplified to "%{url}/aespipe/aespipe-v%{version}.tar.bz2" > BuildRequires: gcc You also need a "BuildRequires: make" line too. > %setup -q -n %{name}-v%{version} You could use "%autosetup -p1 -n %{name}-v%{version}" instead, which may be useful if you will want patches to auto-apply in the future. > %{_mandir}/man1/* This is too greedy, please use "%{_mandir}/man1/aespipe.1*" instead. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2244729 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244729%23c10 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
