https://bugzilla.redhat.com/show_bug.cgi?id=2244984 --- Comment #4 from Davide Cavalca <davide@xxxxxxxxxxxx> --- Thanks for the review! > You should look into moving this library to a subdir of %{_libdir}. That wouldn't work as this is a public library, if we move it other things linking to it wouldn't find it (short of messing with ld.so.conf, which isn't generally advisable). I'll see if I can patch the build system to make it versioned though, as unversioned .so aren't ideal. > You should consider moving the docs to a dedicated docs subpackage. The docs folder seems to provide API documentation which could be placed in the api subpackage. Regarding the controller_callouts docs I wonder if the devel subpackage is the right subpackage to ship these. I'll move these to a -doc subpackage. > As the devel subpackage requires the api subpackage the %license does not have to be included here again. Will remove, thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2244984 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244984%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
