https://bugzilla.redhat.com/show_bug.cgi?id=2244984 Tim Semeijn <tim@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tim@xxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #3 from Tim Semeijn <tim@xxxxxxx> --- This is an unofficial review as I am currently still being sponsored. > openvr-api.x86_64: E: invalid-soname /usr/lib64/libopenvr_api.so libopenvr_api.so You should look into moving this library to a subdir of %{_libdir}. > - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. > Note: Documentation size is 7390917 bytes in 4 files. You should consider moving the docs to a dedicated docs subpackage. The docs folder seems to provide API documentation which could be placed in the api subpackage. Regarding the controller_callouts docs I wonder if the devel subpackage is the right subpackage to ship these. > %files devel > %license LICENSE As the devel subpackage requires the api subpackage the %license does not have to be included here again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2244984 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244984%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
