https://bugzilla.redhat.com/show_bug.cgi?id=2244633 --- Comment #4 from Omair Majid <omajid@xxxxxxxxxx> --- Thanks for taking up the review! (In reply to Neal Gompa from comment #3) > Initial spec review: > > > Release: 0.1%{?dist} > > This should be "0%{?dist}.1" Done, but I am not sure I understand the change. I looked at https://fedoraproject.org/wiki/Package_Versioning_Examples and that still seems to suggest putting 0.1 before %{?dist}. > ExclusiveArch: aarch64 ppc64le s390x x86_64 > ... > > Another question about RHEL 7 here. If we don't care anymore, can we drop > the conditionals? Done. > > %if 0%{?fedora} || 0%{?rhel} >= 9 > > # Setting this macro ensures that only clang supported options will be > > # added to ldflags and cflags. > > %global toolchain clang > > %set_build_flags > > %else > > # Filter flags not supported by clang > > %global dotnet_cflags %(echo %optflags | sed -re 's/-specs=[^ ]*//g') > > %global dotnet_ldflags %(echo %{__global_ldflags} | sed -re 's/-specs=[^ ]*//g') > > export CFLAGS="%{dotnet_cflags}" > > export CXXFLAGS="%{dotnet_cflags}" > > export LDFLAGS="%{dotnet_ldflags}" > > %endif > > Can you please flip this conditional too? I would be happy to. Can you help me understand why, though? The previous conditional suggestions were about putting the future/happy path first, and dealing with legacy/fall-back in the "else" clause. This is already set up that way. In the future, we can simplify to just the the "then" clause: # Setting this macro ensures that only clang supported options will be # added to ldflags and cflags. %global toolchain clang %set_build_flags > > %if 0%{?fedora} > 35 > > # lttng in Fedora > 35 is incompatible with .NET > > export COMPlus_LTTng=0 > > %endif > > Doesn't this also affect RHEL 9+ (or at least RHEL 10+)? It doesn't affect RHEL 9 (which has lttng-ust 2.12, just like Fedora 35). I don't know what happens in a RHEL 10 context, which might inherit lttng-ust 2.13.x from Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2244633 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244633%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
