https://bugzilla.redhat.com/show_bug.cgi?id=2244633 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: > Release: 0.1%{?dist} This should be "0%{?dist}.1" > %if 0%{?fedora} || 0%{?rhel} >= 8 > ExclusiveArch: aarch64 ppc64le s390x x86_64 > %else > ExclusiveArch: x86_64 > %endif Can we flip this like so? %if 0%{?rhel} && 0%{?rhel} < 8 ExclusiveArch: x86_64 %else ExclusiveArch: aarch64 ppc64le s390x x86_64 %endif Or if RHEL 7 doesn't matter anymore, can we just simplify to: ExclusiveArch: aarch64 ppc64le s390x x86_64 > %if 0%{?fedora} || 0%{?rhel} > 7 > BuildRequires: glibc-langpack-en > %endif Another question about RHEL 7 here. If we don't care anymore, can we drop the conditionals? > %if 0%{?fedora} || 0%{?rhel} >= 9 > # Setting this macro ensures that only clang supported options will be > # added to ldflags and cflags. > %global toolchain clang > %set_build_flags > %else > # Filter flags not supported by clang > %global dotnet_cflags %(echo %optflags | sed -re 's/-specs=[^ ]*//g') > %global dotnet_ldflags %(echo %{__global_ldflags} | sed -re 's/-specs=[^ ]*//g') > export CFLAGS="%{dotnet_cflags}" > export CXXFLAGS="%{dotnet_cflags}" > export LDFLAGS="%{dotnet_ldflags}" > %endif Can you please flip this conditional too? > %if 0%{?fedora} > 35 > # lttng in Fedora > 35 is incompatible with .NET > export COMPlus_LTTng=0 > %endif Doesn't this also affect RHEL 9+ (or at least RHEL 10+)? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2244633 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202244633%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
