https://bugzilla.redhat.com/show_bug.cgi?id=2241701 --- Comment #4 from Marc-Andre Lureau <marcandre.lureau@xxxxxxxxxx> --- (In reply to Benson Muite from comment #2) > > Comments: > a) The source can be downloaded using the full git hash. Consider using > %global commit d6e6b99ba6ec2b6b2502aa46dcb57d6b0fa53787 > Source0: > https://android.googlesource.com/platform/hardware/google/aemu/+archive/ > %{commit}.tar.gz That creates issue with file naming, subdirectory etc.. Not really worth it imho, but I am all for elegant working suggestions :) > b) Maybe check if upstream will add a license file I reached them, in the meantime I added a LICENSE file > c) Build failures on ppc64, s390x and i686 > https://koji.fedoraproject.org/koji/taskinfo?taskID=107283304 Yeah, updated thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2241701 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241701%23c4 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
