https://bugzilla.redhat.com/show_bug.cgi?id=2241701 --- Comment #3 from Marc-Andre Lureau <marcandre.lureau@xxxxxxxxxx> --- (In reply to Petr Menšík from comment #1) > I would recommend using %autosetup. > ok > devel subpackage does not own %{_libdir}/pkgconfig or depend on package > owning it. Otherwise it seems good. I don't think it's necessary, looking at other packages. > > Also I think %{?ldconfig_scriptlets} should be used for forward > compatibility if it gets undefined. It is no-op on recent releases anyway. I'll drop it. thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2241701 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202241701%23c3 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue